Add ingress class support for Contour #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-ingress-class` command flag. When set, the specified class is used to annotate the generated HTTPProxy objects.
stefanprodan
force-pushed
the
ingress-class
branch
from
f3e331d
to
ff94e14
Compare
Co-authored-by: Takeshi Yoneda <cz.rk.t0415y.g@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 54.93% 54.95% +0.01%
==========================================
Files 62 62
Lines 5235 5241 +6
==========================================
+ Hits 2876 2880 +4
- Misses 1942 1944 +2
Partials 417 417
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-ingress-classcommand flag andingressClassHelm chart option. When set e.g.-ingress-class=contour, the specified class will be used to annotate the generated HTTPProxy objects.Fix: #582