Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istio: Add source labels to analysis matching rules #594

Merged
merged 3 commits into from
May 27, 2020

Conversation

stefanprodan
Copy link
Member

This PR adds the sourceLabels filed to the Canary CRD. This allows running an A/B test using source labels matches when a service is attached to the Istio mesh gateway.

Example:

kind: Canary
metadata:
  name: backend
spec:
  provider: istio
  service:
    port: 9898
    gateways:
      - mesh
  analysis:
    interval: 15s
    threshold: 10
    iterations: 10
    match:
    - sourceLabels:
        app: frontend

Fix: #580

For testing update the CRD with kubectl apply -f https://raw.githubusercontent.com/weaveworks/flagger/istio-source-labels/artifacts/flagger/crd.yaml before using sourceLabels.

@codecov-io
Copy link

codecov-io commented May 18, 2020

Codecov Report

Merging #594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          62       62           
  Lines        5303     5303           
=======================================
  Hits         2917     2917           
  Misses       1959     1959           
  Partials      427      427           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a3b9d...4f299e5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Correlation between two canary active deployments
3 participants