Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change builtin metrics to work with Istio >= 1.5 #623

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Change builtin metrics to work with Istio >= 1.5 #623

merged 1 commit into from
Jun 17, 2020

Conversation

stefanprodan
Copy link
Member

This PR changes the builtin request-duration metric query to be compatible with Istio telemetry v2 (Istio >= 1.5).

mathetake
mathetake approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@stefanprodan stefanprodan merged commit fa25872 into master Jun 17, 2020
@stefanprodan stefanprodan deleted the istio-latency branch June 17, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @mathetake