Do not promote when not ready on skip analysis #695
Conversation
| if !canary.SkipAnalysis() { | ||
| return false | ||
| } | ||
|
|
||
| // regardless if analysis is being skipped, rollback if canary failed to progress |
There was a problem hiding this comment.
without this block, flagger immediately tries to promote the new version which at this point has 0 healthy pods.
|
@worldtiki have you managed to reproduce the condition when Flagger would promote a canary with 0 healthy pods? If so then it will be great to add an e2e test to https://github.com/weaveworks/flagger/blob/master/test/e2e-istio-tests.sh |
Sure. Should I add a new test or create a separate file? That one looks like it's only testing happy paths where as this is more of an edge case. |
|
@worldtiki you could add a new file and append it to Istio ClircleCI job definition here https://github.com/weaveworks/flagger/blob/master/.circleci/config.yml#L97 Thanks! |
| @@ -3,21 +3,6 @@ | |||
| # This script runs e2e tests for Canary, B/G and A/B initialization, analysis and promotion | |||
| # Prerequisites: Kubernetes Kind and Istio | |||
|
|
|||
| set -o errexit | |||
There was a problem hiding this comment.
Can you please add back set -o errexit to all scripts
There was a problem hiding this comment.
Of course.
ps: I don't know if this new structure of tests makes sense. I'm happy to change this if you want.
Fixes #362