-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A/B testing support for Gloo Edge ingress controller #765
Conversation
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
==========================================
+ Coverage 56.02% 56.47% +0.44%
==========================================
Files 67 67
Lines 5340 5383 +43
==========================================
+ Hits 2992 3040 +48
+ Misses 1891 1882 -9
- Partials 457 461 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kdorosh 🏅
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
A/B testing support for Gloo Edge ingress controller
Resolves #707 , which is related to solo-io/gloo#3726
The approach here is to replace Gloo
UpstreamGroup
s in the flagger implementation with GlooRouteTable
s, which additionally support header/method matching used in A/B testing. For this to work, we needed to add and leverage the newinheritablePathMatcher
field on GlooRouteTable
s, thus these changes will only work in Gloo Edge 1.6.0-beta22 and higher. (Gloo Edge 1.6.0 release is slated for end of year)Unit and integration tests all pass locally. The documented guide has been updated and confirmed as well.
Appreciate the attention to developer experience and developer guide, thanks!