Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A/B testing support for Gloo Edge ingress controller #765

Merged
merged 21 commits into from
Jan 4, 2021

Conversation

kdorosh
Copy link
Contributor

@kdorosh kdorosh commented Dec 22, 2020

Resolves #707 , which is related to solo-io/gloo#3726

The approach here is to replace Gloo UpstreamGroups in the flagger implementation with Gloo RouteTables, which additionally support header/method matching used in A/B testing. For this to work, we needed to add and leverage the new inheritablePathMatcher field on Gloo RouteTables, thus these changes will only work in Gloo Edge 1.6.0-beta22 and higher. (Gloo Edge 1.6.0 release is slated for end of year)

Unit and integration tests all pass locally. The documented guide has been updated and confirmed as well.

Appreciate the attention to developer experience and developer guide, thanks!

Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #765 (005e392) into main (cff742d) will increase coverage by 0.44%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
+ Coverage   56.02%   56.47%   +0.44%     
==========================================
  Files          67       67              
  Lines        5340     5383      +43     
==========================================
+ Hits         2992     3040      +48     
+ Misses       1891     1882       -9     
- Partials      457      461       +4     
Impacted Files Coverage Δ
pkg/router/gloo.go 81.63% <83.33%> (+12.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff742d...005e392. Read the comment docs.

@kdorosh kdorosh marked this pull request as ready for review December 22, 2020 15:30
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kdorosh 🏅

Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
Signed-off-by: Kevin Dorosh <kcdorosh@gmail.com>
@stefanprodan stefanprodan merged commit e62668a into fluxcd:main Jan 4, 2021
mayankshah1607 pushed a commit to mayankshah1607/flagger that referenced this pull request Feb 20, 2021
A/B testing support for Gloo Edge ingress controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for session affinity for Gloo canaries
3 participants