Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the behavior of skipAnalysis during the initialization #796

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

jhuliano
Copy link
Contributor

@jhuliano jhuliano commented Jan 28, 2021

Document the behavior of skipAnalysis during the initialization process as mentioned on #515.
Also, on questions, replaced the bold text with header4 (that way users can link directly to the questions).

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jhuliano 🏅

Signed-off-by: Jhuliano Skittberg Moreno <jhuliano.moreno@typeform.com>
Signed-off-by: Jhuliano Skittberg Moreno <jhuliano.moreno@typeform.com>
@stefanprodan
Copy link
Member

@jhuliano you need to signoff your commit, see https://github.com/fluxcd/flagger/pull/796/checks?check_run_id=1783833814

@stefanprodan stefanprodan merged commit 118cac5 into fluxcd:main Jan 28, 2021
@jhuliano jhuliano deleted the faq-improvements branch January 28, 2021 12:46
stefanprodan added a commit that referenced this pull request Jan 28, 2021
Document the behavior of skipAnalysis during the initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants