Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP request header manipulation rules #82

Merged
merged 6 commits into from
Mar 6, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Mar 6, 2019

This PRs adds support for appending headers to HTTP requests.

apiVersion: flagger.app/v1alpha3
kind: Canary
spec:
  service:
    port: 9898
    headers:
      request:
        add:
          x-envoy-upstream-rq-timeout-ms: "15000"
          x-envoy-max-retries: "10"
          x-envoy-retry-on: "gateway-error,connect-failure,refused-stream"

Fix: #81

@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.17%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   54.56%   54.74%   +0.17%     
==========================================
  Files          13       13              
  Lines        1532     1538       +6     
==========================================
+ Hits          836      842       +6     
  Misses        556      556              
  Partials      140      140
Impacted Files Coverage Δ
pkg/router/istio.go 80.82% <90%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e094c2a...8b6aa73. Read the comment docs.

@stefanprodan stefanprodan changed the title Add header manipulation rules Add support for HTTP request header manipulation rules Mar 6, 2019
@stefanprodan stefanprodan merged commit f3a4201 into master Mar 6, 2019
@stefanprodan stefanprodan deleted the headers-ops branch March 6, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants