feat: added WaitingPromotion phase #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@jblackburn21 can you please add WaitingPromotion to docs in here: https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/how-it-works.md#canary-status
jblackburn21
force-pushed
the
waiting-promotion-phase
branch
from
ec0fea3
to
f7e64f9
Compare
…ioning into the phase Signed-off-by: Jason Blackburn <jason.blackburn@outlook.com>
jblackburn21
force-pushed
the
waiting-promotion-phase
branch
from
f7e64f9
to
f0bf521
Compare
|
Updated the documentation |
Codecov Report
@@ Coverage Diff @@
## main #859 +/- ##
==========================================
- Coverage 56.75% 56.68% -0.08%
==========================================
Files 67 67
Lines 5430 5439 +9
==========================================
+ Hits 3082 3083 +1
- Misses 1888 1896 +8
Partials 460 460
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #497
Added WaitingPromotion phase to generate a single alert and to have a status that can be read in devops pipelines
Signed-off-by: Jason Blackburn jason.blackburn@outlook.com