Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SMI v1alpha3 router #896

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Implement SMI v1alpha3 router #896

merged 1 commit into from
Apr 29, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 28, 2021

This PR adds support for SMI TrafficSplit v1alpha3.

For service mesh providers that require this version set:

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: my-canary
spec:
  provider: "smi:v1alpha3"

Note that for SMI compatible service mesh solutions like Open Service Mesh, Consul Connect or Nginx Service Mesh,
Prometheus MetricTemplates can be used to implement the request success rate and request duration checks.

Fix: #551

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Apr 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #896 (593f450) into main (fcac992) will increase coverage by 0.05%.
The diff coverage is 59.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   56.58%   56.64%   +0.05%     
==========================================
  Files          68       69       +1     
  Lines        5565     5662      +97     
==========================================
+ Hits         3149     3207      +58     
- Misses       1946     1977      +31     
- Partials      470      478       +8     
Impacted Files Coverage Δ
pkg/router/factory.go 0.00% <0.00%> (ø)
pkg/router/smi_v1alpha3.go 65.16% <65.16%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcac992...593f450. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make SMI apiVersion configurable for SMI based service mesh providers
2 participants