Create New Job when Canary's Interval changes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently whenever the Canary analysis interval changes, flagger does not reflect this into canary's job. - This change will make sure the canary analysis interval got updated whenever the Canary object's interval changes
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 54.8% 54.59% -0.22%
==========================================
Files 13 13
Lines 1540 1546 +6
==========================================
Hits 844 844
- Misses 556 562 +6
Partials 140 140
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 54.8% 54.59% -0.22%
==========================================
Files 13 13
Lines 1540 1546 +6
==========================================
Hits 844 844
- Misses 556 562 +6
Partials 140 140
Continue to review full report at Codecov.
|
|
Fixes #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not reflect this into canary's job.
the Canary object's interval changes
@stefanprodan