Remove problematic nulls from Grafana dashboard #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Grafana complain when loading dashboard JSON with nulls in these "current" fields. Signed-off-by: Kevin Bell <kebel@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Grafana (tested with version 7.5.5) produce errors like this when importing or opening (when passed in through a config file) the current dashboard JSON:
This stack trace is subsequently shown in the UI:
I confirmed that the problem exists in Grafana installed by the Helm chart in this project with
--set image.tag=7.5.5as well as Amazon Managed Service for Grafana (AMG) with Grafana version 7.5.5.Simply removing the offending
"current": nullpairs seems to make things work okay. I confirmed that the code from this PR can be imported successfully into the Helm-installed Grafana with both versions 7.3.4 (current default) as well as 7.5.5. I also tested that it works as expected in AMG with Grafana version 7.5.5.