Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

Add valueFileSecrets example to Redis release #1

Merged
merged 4 commits into from
Dec 27, 2018

Conversation

stefanprodan
Copy link
Member

@stefanprodan
Copy link
Member Author

@squaremo can you please review this?

Thanks

@squaremo
Copy link
Member

If we're using an unexcrypted secret, and just suggesting people use sealed secrets, do we need the sealed-secret chart release?

@stefanprodan
Copy link
Member Author

I've put the sealed-secret chart release in this repo so I can link to it when people ask about secrets. I can remove it or use the ignore annotation, we don't have an example for that anyway.

@squaremo
Copy link
Member

Your gitops-helm repo has the more complete example (which you can point to) -- I think you can remove it here.

@stefanprodan
Copy link
Member Author

Done

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good to show this feature -- thanks Stefan

@stefanprodan stefanprodan merged commit efa4f05 into master Dec 27, 2018
@stefanprodan stefanprodan deleted the valueFileSecrets branch December 27, 2018 11:57
davidpolaniaac added a commit to davidpolaniaac/flux-get-started that referenced this pull request Apr 12, 2020
Add valueFileSecrets example to Redis release
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants