Run manifest policy update unit tests in parallel

fluxcd · Dec 11, 2019 · 38ad933 · 38ad933
1 parent 562384f
commit 38ad933
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkg/cluster/kubernetes/policies_test.go b/pkg/cluster/kubernetes/policies_test.go
@@ -186,13 +186,15 @@ func TestUpdatePolicies(t *testing.T) {
 		},
 	} {
 		t.Run(c.name, func(t *testing.T) {
-			caseIn := templToString(t, annotationsTemplate, c.in)
-			caseOut := templToString(t, annotationsTemplate, c.out)
+			cLocal := c // Use copy to avoid races between parallel tests
+			t.Parallel()
+			caseIn := templToString(t, annotationsTemplate, cLocal.in)
+			caseOut := templToString(t, annotationsTemplate, cLocal.out)
 			resourceID := resource.MustParseID("default:deployment/nginx")
 			manifests := NewManifests(ConstNamespacer("default"), log.NewLogfmtLogger(os.Stdout))
-			out, err := manifests.UpdateWorkloadPolicies([]byte(caseIn), resourceID, c.update)
-			assert.Equal(t, c.wantErr, err != nil, "unexpected error value: %s", err)
-			if !c.wantErr {
+			out, err := manifests.UpdateWorkloadPolicies([]byte(caseIn), resourceID, cLocal.update)
+			assert.Equal(t, cLocal.wantErr, err != nil, "unexpected error value: %s", err)
+			if !cLocal.wantErr {
 				assert.Equal(t, string(out), caseOut)
 			}
 		})