Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

If configured branch didn't exist at first launch, flux won't find it later #2370

Closed
yellowmegaman opened this issue Aug 16, 2019 · 1 comment · Fixed by #2371
Closed

If configured branch didn't exist at first launch, flux won't find it later #2370

yellowmegaman opened this issue Aug 16, 2019 · 1 comment · Fixed by #2371
Labels
blocked-needs-validation Issue is waiting to be validated before we can proceed bug

Comments

@yellowmegaman
Copy link

Describe the bug
When pointing flux on non-existing (yet) branch in git, it will say branch "does not exist", even if branch is created after that. Have to manually kill flux pod.

To Reproduce
Steps to reproduce the behaviour:

  1. GKE cluster + flux + github
  2. Launch flux
  3. point it to repo A branch A
  4. it will say "does not exist"
  5. create that branch
  6. still get error until delete flux pod to restart.

Expected behavior
Flux should just work with created branch

Logs

2019-08-16 14:53:24.025 MSK
ts=2019-08-16T11:53:24.024322937Z caller=loop.go:85 component=sync-loop err="git repo not ready: configured branch 'killpinbug' does not exist"
2019-08-16 14:56:24.025 MSK
ts=2019-08-16T11:56:24.025343062Z caller=loop.go:85 component=sync-loop err="git repo not ready: configured branch 'killpinbug' does not exist"

Additional context
Add any other context about the problem here, e.g

  • Flux version: 1.13.1
  • Kubernetes version: 1.13.7-gke.8
  • Git provider: github
  • Container registry provider: gcr.io
@yellowmegaman yellowmegaman added blocked-needs-validation Issue is waiting to be validated before we can proceed bug labels Aug 16, 2019
hiddeco added a commit that referenced this issue Aug 16, 2019
@hiddeco
Fetch before branch check during initial clone
d7f3d48 
As Flux will retry until it succeeds, the initial overview of the
repository it fetched during the first step may be outdated later
on (as reported in #2370). To overcome this issue: fetch from
remote before we perform the branch check.
@hiddeco hiddeco mentioned this issue Aug 16, 2019
Merged
@yellowmegaman
Copy link
Author

That was fast 🥇
Thank you! Hope it will make it's way in some release soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked-needs-validation Issue is waiting to be validated before we can proceed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch before branch check during initial clone fluxcd/flux
1 participant
@yellowmegaman