This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Refactor update and release packages to break some dependencies #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interest of getting all the manifest-updating code in one place, and breaking some dependencies, this commit - moves the type policy.Update and associated code to update.Policy, where the other kinds of update are - reimplements the commit message so that it doesn't get calculated via constructing events, which aren't themselves used anywhere - removes the unused policy events, excepting EventUpdatePolicy, which is still used (just not as an event type) - breaks the dependency of cluster.Manifests on the update package, which will make it easier to refactor other code - moves the application of policy, which was inlined in the daemon, into the release package
squaremo
force-pushed
the
refactor/update-and-release
branch
from
111454a to
fb7b4af
Compare
squaremo
added
the
blocked-rebase
|
@squaremo are you planning to revive this at some point or should we close it? |
Good question -- aside from a bit of renaming faff, it does have some useful tidies. I'll give reviving a go, and close if that's at all tricky. |
|
Oh yeah, this comes off rather badly in a collision with #2201. Never mind, maybe another time .. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just one commit -- the other will be rebassed away once #1027 is merged.(EDIT: the rebass is accomplished)The main change here is to move policy update specs into update/ and their application into release/, thus putting them in the same place as image updates (i.e, releases) and treating them more or less uniformly.
Part of this was breaking the dependence of the cluster package on the update package, which itself was a whisker away from depending on cluster. This'll make it easier to move more things around.