This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Include initContainers in images to fetch #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symptom: images used in initContainers, but not elsewhere, don't get metadata fetched for them, and don't get automated updates. Fix: the ImagesToFetch method of the cluster, supplied to the image DB as the way to get a list of all the images to fetch, didn't look in initContainers. So, make it do that.
stefanprodan
approved these changes
Sep 18, 2018
|
Brill, thanks very much for the quick turnaround on review Stefan 🍬 |
squaremo
added a commit
that referenced
this pull request
Sep 26, 2018
…apsulation Include initContainers in images to fetch
squaremo
added a commit
that referenced
this pull request
Oct 4, 2018
This pulls the release branch 1.7.x back into master, so that master gets the changelog entry for the 1.7.1 release. Below are the cherry-picked changes that were on the release/1.7.x branch at the time of this merge. * origin/release/1.7.x: Update changelog for v1.7.1 Merge pull request #1389 from dholbach/fix-827 Merge pull request #1372 from weaveworks/issue/1371-podcontroller-encapsulation Merge pull request #1369 from alanjcastonguay/patch-1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom: images used in initContainers, but not elsewhere, don't get
metadata fetched for them, and don't get automated updates.
Fix: the ImagesToFetch method of the cluster, supplied to the image DB
as the way to get a list of all the images to fetch, didn't look in
initContainers. So, make it do that.
Fixes #1371.