Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Include parsed string in error for ParseRef() #1407

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Include parsed string in error for ParseRef() #1407

merged 1 commit into from
Oct 1, 2018

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Sep 28, 2018

Closes #1290

squaremo
squaremo approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thank you.

Can you find another issue to be in hacktoberfest to replace the one you've fixed please :-S

@rndstr
Copy link
Contributor Author

rndstr commented Oct 1, 2018

Can you find another issue to be in hacktoberfest to replace the one you've fixed please :-S

Nominated #1116

@rndstr rndstr merged commit 5216d48 into master Oct 1, 2018
@rndstr rndstr deleted the issue/1290-include-ref-in-error branch October 1, 2018 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rndstr @squaremo