This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Helm Chart allow mounting of docker credentials file #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneramey
changed the title
|
Flux has native support for EKS/ECR authentication since 1.9.0 see #1619 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1310 as an alternative solution to #1314
Enables fluxd to connect to private registries via the Helm Chart. This is done by mounting a custom docker config file from a Kubernetes Secret. The credentials are not placed in the Helm values or overrides, but instead must be side-loaded.
This is compatible with https://github.com/bzon/ecr-k8s-secret-creator per #1314 (comment)