Garbage collection dry run

[jan-schumacher]

I added a new syncGarbageCollection.dry option for helm chart and deployment. With this option activated it is irrelevant how syncGarbageCollection.enabled is set, the garbage collection will run in a trace mode. Only logs appear in the console but no resources are touched.
I created a Test for this behaviour in the style of the existing tests.

Fixes #1990

[squaremo]

Great idea, thanks for putting your time into this ✋ (high five!)

I made a few suggestions, see what you think. If you don't think you'll have capacity to spend more time on this PR, no worries, just let us know :-)

[jan-schumacher]

ci/circleci: e2e-testing — Your tests failed on CircleCI

Unfortunately I can’t run the e2e tests because I miss the app kind. Is that an alias?

[hiddeco]

@jan-schumacher kind is Kubernetes in Docker, it should also work with minikube (after rebasing on master) by running make e2e.

[2opremio]

Unfortunately I can’t run the e2e tests because I miss the app kind. Is that an alias?

@jan-schumacher You will be able to run them locally if you rebase on master (thanks to #2063 ) by running make e2e

Regardless, the current error is:

Error: render error in "flux/templates/deployment.yaml": template: flux/templates/deployment.yaml:194:24: executing "flux/templates/deployment.yaml" at <.Values.syncGarbageCollection.enabled>: enabled is not a method but has arguments
Exited with code 1

[jan-schumacher]

Unfortunately I can’t run the e2e tests because I miss the app kind. Is that an alias?

@jan-schumacher You will be able to run them locally if you rebase on master (thanks to #2063 ) by running make e2e

Regardless, the current error is:

Error: render error in "flux/templates/deployment.yaml": template: flux/templates/deployment.yaml:194:24: executing "flux/templates/deployment.yaml" at <.Values.syncGarbageCollection.enabled>: enabled is not a method but has arguments
Exited with code 1

@hiddeco
Does that come from the change of the equation?

{{- if .Values.syncGarbageCollection.enabled and not .Values.syncGarbageCollection.dry}}
- --sync-garbage-collection={{ .Values.syncGarbageCollection.enabled }}
{{- else if .Values.syncGarbageCollection.dry }}
- --sync-garbage-collection-dry={{ .Values.syncGarbageCollection.dry }}
{{- end }}

Should I rather do it like this?

{{- if .Values.syncGarbageCollection.enabled }}
{{- if not .Values.syncGarbageCollection.dry }}
- --sync-garbage-collection={{ .Values.syncGarbageCollection.enabled }}
{{- end }}
{{- else if .Values.syncGarbageCollection.dry }}
- --sync-garbage-collection-dry={{ .Values.syncGarbageCollection.dry }}
{{- end }}

[hiddeco]

@jan-schumacher please take a look at the Helm documentation about operators https://helm.sh/docs/chart_template_guide/#operators-are-functions

[jan-schumacher]

@jan-schumacher please take a look at the Helm documentation about operators https://helm.sh/docs/chart_template_guide/#operators-are-functions

I see, thanks mate ;) not this is what i call syntactical candy.

[hiddeco]

@jan-schumacher this is shaping up well, can you smash your commits together into one?

[hiddeco]

Looking good, thanks @jan-schumacher 🥇