-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see how this benefits from the initial work for GPG signatures, and a sought after feature! 🎖️
Please take a look at my (minor) comments.
Thanks for your comments, I applied your recommendations! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, and can you please add the new flag to the daemon documentation?
Nice, I hope we will have this feature in the next release |
@arsiesys couple of days have gone by since the last review, are you still planning to incorporate the feedback from Stefan and Michael? |
Hello, yes, I will. A bit lack of time to do that lately ! 😬 |
@arsiesys no worries, if it does not fit your schedule right now I'd be happy to make the adjustments. Just let me know. |
If the parameter --git-secret is set to true and a .gitsecret directory exist in the root of the git then, reveal the secrets using gpg key stored in gpg store.
Nice work @arsiesys ! |
@stefanprodan should the chart be updated too? What do you need for it - simply a flag to activate |
@davidkarlsen for experimental features there is an additional flag in the chart: https://github.com/fluxcd/flux/blob/master/chart/flux/values.yaml#L265 |
Can i ask a question here...
Imported successfully
Get ERROR
When open a shell of the pod , i can import the gpg key and do git reveal, could anybody help? |
Hello,
To answer to some needs, I made a change to handle the git repository using git-secret. This allow us to encrypt our secrets.
https://git-secret.io/
If the parameter --git-secret is set to true in fluxd configuration and a .gitsecret directory exist in the root of the git, flux will execute a "git secret reveal -f" in the working git.
Indeed, to make it work, you need to have the key in the gpg keystore, that's why we are using the --git-gpg-key-import option for that. Happy it was already there.
I am not fully comfortable with GO, so I am open to any suggestion that could be easily applied on my changes. For any more complicated changes, please take the handover on this PR if you are really interested or give me good clues :p.
Related Issues:
#1676