This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
fixing prometheus scrape annotation #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Jul 22, 2019
timja
approved these changes
Jul 22, 2019
hiddeco
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Thank you for the contribution @adusumillipraveen, and for the review @timja. Looking good 🌻
squaremo
force-pushed
the
fixprometheusannotation
branch
from
135a10f
to
90bc383
Compare
squaremo
added a commit
that referenced
this pull request
Jul 25, 2019
fixing prometheus scrape annotation
squaremo
added a commit
that referenced
this pull request
Jul 25, 2019
fixing prometheus scrape annotation
squaremo
added a commit
that referenced
this pull request
Jul 25, 2019
fixing prometheus scrape annotation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing prometheus scrape annotation . Currently Azure prometheus agent data collection is not working unless we add a custom annotation / use service end point.
Slack conversation : https://weave-community.slack.com/archives/C4U5ATZ9S/p1563786967009700?thread_ts=1563785856.008800&cid=C4U5ATZ9S