This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Remove Helm operator from codebase #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/remove
branch
4 times, most recently
from
c06a2ef
to
26eb6ca
Compare
hiddeco
added a commit
that referenced
this pull request
Aug 13, 2019
This commit has overlap with work done in #2329. We do however need to disable the push of images before we actually remove the code, to be able to safely switch to `master` in the `fluxcd/helm-operator` repository. As otherwise the prerelease images will have builds from mixed origins.
hiddeco
force-pushed
the
helm/remove
branch
3 times, most recently
from
8efdb51
to
a9f8b0a
Compare
hiddeco
force-pushed
the
helm/remove
branch
5 times, most recently
from
ac5fcc3
to
badb6fb
Compare
stefanprodan
approved these changes
Aug 15, 2019
Or to be more specific: - removed `integrations/` - removed `cmd/helm-operator` - changed existing imports to `github.com/fluxcd/helm-operator`
But still install it during the end to end tests (from the latest official release), as Flux has some features (e.g. image updates) that work with `HelmRelease` objects.
And reference to this file in `CHANGELOG.md`.
They are now managed as a child project in RTD, and the docs reside in the Helm operator repository.
This commit adds support for HelmRelease v1 resources with backwards compatability for v1beta1 resources, it also reintroduces some of the removed `integrations/` packages, as those resources have been removed from the Helm operator. The v1 resource is prioritized over v1beta1 resources, as Flux is only aware of the resource kind and not the api version. The prioritization means that if there are two resources with the same namespace and name, Flux will only see the v1 resource. The fallback is based on returned errors from the API, this comes at a cost, as errors during the first try may actually be relevant. The version of `github.com/fluxcd/helm-operator` has been pinpointed on `1.0.0-rc1`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Helm operator home is
fluxcd/helm-operator.github.com/fluxcd/helm-operatorcode-generatorelementsDockerfileMakefileREADME.md