This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Hotfix: updates of autodetected images in HelmReleases #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
hotfix/2399-auto-detected-images
branch
from
93ff03d
to
83854c2
Compare
Instead of returning the error when an image map for a container name (= alias) could not be found, it should fallthrough and attempt to just update the workload using the container name. If we do not do this it blocks the updates of automatically detected images, as reported in #2399.
hiddeco
force-pushed
the
hotfix/2399-auto-detected-images
branch
from
83854c2
to
4fd6f11
Compare
squaremo
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning the error when an image map for a container
name (= alias) could not be found, it should fall through and attempt
to just update the workload using the container name. If we do not
do this it blocks the updates of automatically detected images, as
reported in #2399.