Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

e2e: Add basic sync test #2569

Merged
merged 6 commits into from
Nov 1, 2019
Merged

e2e: Add basic sync test #2569

merged 6 commits into from
Nov 1, 2019

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Oct 31, 2019

As part of it:

  1. Implicitly set the environment when importing lib/env.bash
    (needed so that other library files can use the environment variables)
  2. Allow accessing the git server (securely) through port-forwarding as
    part of install_git_srv
  3. Merge installing gitsrv and creating the git ssh secret (so that we
    can reuse the underlying ssh keys for (2))

@2opremio 2opremio requested a review from hiddeco October 31, 2019 18:57
test/e2e/lib/install.bash Outdated Show resolved Hide resolved
test/e2e/12_sync.bats Outdated Show resolved Hide resolved
@2opremio 2opremio force-pushed the sync-test branch 3 times, most recently from 0a7c49d to 9f236b5 Compare November 1, 2019 08:57
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open suggestion, other than that looking good to me 💯

As part of it:

1. Make automatically set the environment when importing lib/env.bash
   (needed so that other library files can use the environment variables)
2. Allow accessing the git server (securely) through port-forwarding as
   part of install_git_srv
3. Merge installing gitsrv and creating the git ssh secret (so that we
   can reuse the underlying ssh keys for (2))
@2opremio 2opremio merged commit a41aef2 into fluxcd:master Nov 1, 2019
@2opremio 2opremio deleted the sync-test branch November 1, 2019 11:50
@2opremio 2opremio added this to the 1.16.0 milestone Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants