Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

e2e: Add sync failure test #2581

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Nov 5, 2019

The test updates and duplicates a resource, making sure syncing catches the problem and no update is performed in the cluster.

The test updates and duplicates a resource, making sure syncing
catches the problem and no update is performed in the cluster.
test/e2e/12_sync.bats Outdated Show resolved Hide resolved
test/e2e/12_sync.bats Outdated Show resolved Hide resolved
@2opremio
Copy link
Contributor Author

2opremio commented Nov 5, 2019

@hiddeco PTAL

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about comparisons and local variables, but the test itself looks good to me ⭐

test/e2e/12_sync.bats Outdated Show resolved Hide resolved
@2opremio 2opremio merged commit a58a51b into fluxcd:master Nov 6, 2019
@2opremio 2opremio deleted the e2e-sync-failure branch November 6, 2019 09:12
@2opremio 2opremio added this to the 1.16.0 milestone Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants