This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Run manifest image update unit tests in parallel #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I previously disabled parallel tests in 7d9e02d thinking it would fix the flaky unit tests in CircleCI. Parallelization wasn't the culprit. On the way I also found out that tests were not really running in parallel due to `t.Parallel()` being called after the test is run.
|
Unit tests now take ~1 minute ( https://circleci.com/gh/fluxcd/flux/9076 ) vs 1:20 in master ( https://circleci.com/gh/fluxcd/flux/9079 ) |
hiddeco
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously disabled parallel tests in 7d9e02d thinking it would fix the flaky unit tests in CircleCI.
Parallelization wasn't the culprit. On the way I also found out that tests were not really running in parallel due to
t.Parallel()being called after the test is run.Follow up from #2674 , #2672 and #1507