This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Raising error if arguments are provided to version and install commands #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims to conform to the same behavior with other commands: `install` and `version` ones are not expecting to receive arguments, so raising the error `errorWantedNoArgs`. In addition, provided some little test coverage and added the required flags for the `install` command since `--git-email` was missing but marked as mandatory. Pretty sure the change is breaking for users using the installation method via the CLI instead of the Helm Chart: they could have automation scripts that are pushing arguments and these could break. Closes fluxcd#2808
2opremio
approved these changes
Jan 31, 2020
Thanks a lot! |
Ah, crap, I should had waited for CI. I would have sworn to have seen a green tick. |
Nevermind, JFI sharing my test suite result:
|
Yeah, tests passed, I have too easy a trigger |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to conform to the same behavior with other commands:
install
andversion
ones are not expecting to receive arguments, so raising the errorerrorWantedNoArgs
.In addition, provided some little test coverage and added the required flags for the
install
command since--git-email
was missing but marked as mandatory.Pretty sure the change is breaking for users using the installation method via the CLI instead of the Helm Chart: they could have automation scripts that are pushing arguments and these could break.
Closes #2808