Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

sysdevguru
Copy link
Contributor

@sysdevguru sysdevguru commented Feb 21, 2020

Fixes #1116

Just made another PR because the origin branch was deleted.
Please review the change, @hiddeco
Thanks in advance

cmd/fluxctl/sync_cmd.go Outdated Show resolved Hide resolved
@hiddeco hiddeco changed the title Issue/1116 added new error msg for invalid hostname in repo url Dedicated error for unresolvable Git hostname Feb 24, 2020
@hiddeco hiddeco added the UX In pursuit of a delightful user experience label Feb 24, 2020
@sysdevguru sysdevguru force-pushed the issue/1116-Added-new-error-msg-for-invalid-hostname-in-repo-url branch from 510abb0 to 0866355 Compare February 28, 2020 08:41
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sysdevguru

@hiddeco hiddeco added this to the 1.19.0 milestone Feb 28, 2020
@hiddeco hiddeco force-pushed the issue/1116-Added-new-error-msg-for-invalid-hostname-in-repo-url branch from 0866355 to 65a36ff Compare February 28, 2020 09:07
@sysdevguru
Copy link
Contributor Author

Thank you @sysdevguru ⭐️

You are welcome

@hiddeco hiddeco merged commit 7e01ec6 into fluxcd:master Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UX In pursuit of a delightful user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"git repo not ready" error message not exactly useful
2 participants