Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove deprecated GH workflows #3452

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Remove deprecated GH workflows #3452

merged 1 commit into from
Mar 31, 2021

Conversation

kingdonb
Copy link
Member

Resolves #3451

Signed-off-by: Kingdon Barrett kingdon@weave.works

Resolves #3451

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@kingdonb kingdonb self-assigned this Mar 26, 2021
@kingdonb
Copy link
Member Author

I will investigate adding snyk, this is filed in response to #3451

There is no urgency to merge this IMHO, if we can add a Snyk scan to this PR and replace what is being removed at the same time. I will find time for this on Monday.

If it comes to a point where this is blocking PRs from merging soon, we can go ahead and merge without the replacement, but I don't think this will take long to resolve.

@kingdonb kingdonb added this to the 1.22.1 milestone Mar 27, 2021
@stefanprodan
Copy link
Member

stefanprodan commented Mar 31, 2021

We can't add Snyk since the CNCF key is for flux2 repo only, we've opened a ticket. I would merge this as it is.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb

@kingdonb kingdonb merged commit ea7736c into master Mar 31, 2021
@stefanprodan stefanprodan deleted the pr-for-3451 branch March 31, 2021 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated GH workflows
2 participants