KSM config: Update for NC v1beta3 API #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alert and provider APIs from notification-controller no longer have status to report readiness. Dashboards should be designed to assume Ready=True for no status. The Flux Cluster Stats dashboard already does this for the objects it shows. Signed-off-by: Sunny <darkowlzz@protonmail.com>
4 tasks
hiddeco
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on fluxcd/notification-controller#540.
The alert and provider APIs from notification-controller no longer have status to report readiness.
Dashboards should be designed to assume Ready=True for no status. The Flux Cluster Stats dashboard already does this for the objects it shows.
NOTE: Similar change is not needed for HelmRepository OCI, which is also losing status in fluxcd/source-controller#1243, because the status is needed for the default type HelmRepository. The Flux Cluster Stats dashboard will show HelmRepository OCI objects as Ready always.