Switch to tonistiigi/xx across controllers for cross-platform builds

[hiddeco]

https://github.com/tonistiigi/xx allows for cross-compilation from Dockerfiles to any platform using the architecture of the builder, which gives native performance. Using this, the source-controller - which had this changed in fluxcd/source-controller#449 - saw a release build time reduction from 40 minutes to 10 (4x less!).

Given the other controllers struggle with the same long duration, we should port their Dockerfiles to make us of this as well. While doing this, it should be taken into account that the GitHub Action workflows should likely be rewritten to make more efficiently use of the Dockerfile during (end-to-end) tests, and could be making use of (commit SHA based) caching and/or a local registry.

This should also still be addressed in the source-controller and image-automation-controller, as documented in fluxcd/source-controller@a871e0b and fluxcd/image-automation-controller@64ca8dc.

To-do

• source-controller Update fluxcd/golang-with-libgit2 to 1.1.1-1 source-controller#449
• kustomize-controller Use tonistiigi/xx for cross-platform builds kustomize-controller#458
• helm-controller Use tonistiigi/xx for cross-platform builds helm-controller#335
• image-automation-controller Update github.com/libgit2/git2go to v31.6.1 image-automation-controller#222
• image-reflector-controller Use tonistiigi/xx for cross-platform builds image-reflector-controller#178
• notification-controller Use tonistiigi/xx for cross-platform builds notification-controller#260

[relu]

Since all of the PRs have been merged I'm going to close this. Great work, @darkowlzz! 🥇

[darkowlzz]

Thanks @relu .

I had a discussion about this issue with @hiddeco a few weeks ago and there were a few more things we wanted to do as part of this issue. As mentioned in the issue description, we wanted to rewrite github action workflows to be able to test the built image and conditionally release it for builds triggered on tags. The concern was that the current release pipelines don't test the built images and we could publish untested images.
After doing some research on how to do this, the apparent solution was to have one single workflow that builds, tests and releases (conditionally). For merge and PR builds, the release step won't be executed. Release step will be run only for tags.

We can reopen this or have another issue to track that, as this issue already covered a lot of build changes.

[hiddeco]

Lets re-open this one as it is clear what it's about.

[relu]

Ah, sorry guys, I missed the "in a future iteration" part and misunderstood the end goal of this issue.

[hiddeco]

This has been taken care of a long time ago already.