Use tonistiigi/xx for cross-platform builds #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Dockerfile to use tonistiigi/xx to cross-compile the manager binaries natively and speed up the multi-arch image build time. Also, update github action for build to enable docker buildx. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
Prevent running the test twice in build workflow by removing the dependency on docker-build on test. Signed-off-by: Sunny <darkowlzz@protonmail.com>
relu
requested changes
Oct 25, 2021
| BUILD_PLATFORMS=linux/amd64 \ | ||
| BUILD_ARGS="--cache-from=type=local,src=/tmp/.buildx-cache \ | ||
| --cache-to=type=local,dest=/tmp/.buildx-cache-new,mode=max" | ||
| - # Temp fix |
There was a problem hiding this comment.
We can now use -cache-from=type=gha --cache-to=type=gha,mode=max as docker/buildx#681 was resolved.
| @@ -12,13 +12,28 @@ jobs: | |||
| steps: | |||
| - name: checkout | |||
| uses: actions/checkout@v2 | |||
| - name: Setup QEMU | |||
There was a problem hiding this comment.
Do we actually need qemu considering we're only building for amd64 in this workflow?
| - name: Setup QEMU | ||
| uses: docker/setup-qemu-action@v1 | ||
| with: | ||
| platforms: all |
There was a problem hiding this comment.
If we do need it, I suppose this should be set to the subset of platforms we actually do support:
Suggested change
| platforms: all | |
| platforms: linux/amd64,linux/arm/v7,linux/arm64 |
relu
approved these changes
Oct 27, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Dockerfile to use tonistiigi/xx to cross-compile the
manager binaries natively and speed up the multi-arch image build
time.
Refer fluxcd/flux2#1910
NOTE: Multi-arch build used to take about 6 minutes on my
machine. Cross-compiling reduces the multi-arch build to under 2
minutes.
Manually tested the built image on amd64 and arm/v7 (raspberry pi).
Haven't tested on arm64.
reconcilers-dev.