Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement defaulting of observedGeneration to -1 in all controllers #2007

Closed
makkes opened this issue Oct 26, 2021 · 4 comments
Closed

Implement defaulting of observedGeneration to -1 in all controllers #2007

makkes opened this issue Oct 26, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@makkes
Copy link
Member

makkes commented Oct 26, 2021 •
edited
Loading

This is a follow-up to fluxcd/kustomize-controller#387 for aligning the behaviour implemented in the fix to that issue to all other controllers:
@makkes makkes added the good first issue Good for newcomers label Oct 26, 2021
@makkes makkes mentioned this issue Oct 26, 2021
Closed
@tomhuang12
Copy link

I would like to work on image-reflector-controller changes.

@tomhuang12 tomhuang12 mentioned this issue Oct 27, 2021
Merged
This was referenced Dec 7, 2021
Closed
Closed
@sbernheim
Copy link

@makkes - I'm planning to submit PR for the image-automation-controller ImageUpdateAutomation type as a classroom example to demonstrate the process for first-time contributors. Feel free to assign it to me if you have no objection.

@makkes
Copy link
Member Author

makkes commented Dec 10, 2021

Thanks @sbernheim. I assigned you.

@sbernheim sbernheim mentioned this issue Dec 10, 2021
Merged
@stefanprodan
Copy link
Member

All done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@makkes @sbernheim @stefanprodan @tomhuang12