Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default observedGeneration to -1 #516

Closed
makkes opened this issue Dec 7, 2021 · 2 comments · Fixed by #517
Closed

Set default observedGeneration to -1 #516

makkes opened this issue Dec 7, 2021 · 2 comments · Fixed by #517
Assignees
@cwyl02
Labels
good first issue Good for newcomers

Comments

@makkes
Copy link
Member

makkes commented Dec 7, 2021

This is a follow-up for the tracking issue fluxcd/flux2#2007.

The default observedGeneration has to be set on the following CRDs:

  • HelmRepository
  • HelmChart
  • GitRepository
  • Bucket
@makkes makkes added the good first issue Good for newcomers label Dec 7, 2021
@cwyl02
Copy link
Contributor

cwyl02 commented Dec 7, 2021

hi @makkes , I am interested in working on this.

@makkes
Copy link
Member Author

makkes commented Dec 7, 2021

hi @makkes , I am interested in working on this.

Right on @cwyl02. I'll assign this to you. Don't hesitate to take fluxcd/image-reflector-controller#189 as a template for this work.

@cwyl02 cwyl02 mentioned this issue Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwyl02 cwyl02

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crds: set default observedGeneration to -1 cwyl02/source-controller
2 participants
@makkes @cwyl02