Flux components Go v1.17 upgrade

[relu]

This is an umbrella issue to keep track of the Go version upgrade work across all of the Flux components.

• pkg Update Go to v1.17 and controller-runtime to v0.11.0 pkg#175
• go-git-providers: upgrade to go v1.17 and logr v1.2 go-git-providers#139
• notification-controller Update Go to v1.17 and controller-runtime to v0.11 notification-controller#279
• source-controller Update Go to v1.17 source-controller#473
• kustomize-controller Update Go to v1.17 and controller-runtime to v0.11 kustomize-controller#478
• image-reflector-controller Update Go to v1.17 image-reflector-controller#190
• image-automation-controller Update Go to v1.17 image-automation-controller#248
• helm-controller Update Go to v1.17 helm-controller#348
• flux2 Update toolkit components and packages #2271
• terraform-provider-flux Update Go to v1.17 terraform-provider-flux#210

[stefanprodan]

We may want to delay this as Go 1.17 mod doesn't work with x/crypto packages.

[relu]

Got it, thanks for the information. We can use this when the time comes.

[stefanprodan]

I see that some issues were fixed, e.g. golang/go#46761

I propose we test the upgrade in source-controller and make sure the multi-arch build works.

[stefanprodan]

Let's block this until Kubernetes client-go and controller-runtime switch to Go 1.17 https://github.com/kubernetes-sigs/controller-runtime/blob/master/go.mod

[relu]

Sounds good to me.

[stefanprodan]

So Kubernetes has switched to Go 1.17 for compiling but go.mod is still on 1.16 format. I propose we do the same, bump Go in CI and in the Dockerfiles to 1.17, leave go.mod as it.

[relu]

@stefanprodan I'm not sure if that applies to our repos. I tried to search for a reason why they decided to do that and found two relevant comments here and here. It looks like this is just because the reporting tools they use are not (yet?) supporting the dependency graph information that go mod 1.17 handles.

On a side note, controller-runtime has the mod changes in place in master right now but there's not yet a released version containing the change if we're still waiting for that to happen.

[stefanprodan]

controller-runtime with Go .1.7 has been released https://github.com/kubernetes-sigs/controller-runtime/blob/v0.11.0/go.mod#L3

@relu Can you update controller-runtime in fluxcd/pkg and rebase your PR? I'm for getting this in now.

[relu]

@stefanprodan definitely, I'll get to it.