Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to v1.17 #473

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Update Go to v1.17 #473

merged 3 commits into from
Jan 5, 2022

Conversation

relu
Copy link
Member

@relu relu commented Oct 27, 2021

I've successfully tested the build on multi-arch using buildx with qemu. I suppose some more thorough testing will be needed though to evaluate the changes.

@relu relu force-pushed the go-v1.17 branch 2 times, most recently from 4f86aa3 to 02f325c Compare October 28, 2021 12:53
@relu relu marked this pull request as ready for review October 28, 2021 12:54
go.mod Outdated Show resolved Hide resolved
@relu relu added the blocked/upstream Blocked by an upstream dependency or issue label Nov 4, 2021
@relu relu marked this pull request as draft December 15, 2021 22:43
@relu relu removed the blocked/upstream Blocked by an upstream dependency or issue label Dec 16, 2021
@relu relu marked this pull request as ready for review December 16, 2021 11:55
go.mod Outdated
github.com/docker/go-metrics v0.0.1 // indirect
github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 // indirect
github.com/fluxcd/pkg/apis/meta v0.10.1
github.com/fluxcd/pkg/apis/meta v0.10.2
github.com/fluxcd/pkg/gittestserver v0.4.2
github.com/fluxcd/pkg/gitutil v0.1.0
github.com/fluxcd/pkg/helmtestserver v0.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are new releases for both gittestserver and helmtestserver with Go 1.17

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, seems I missed these. Thanks!

@relu relu force-pushed the go-v1.17 branch 2 times, most recently from 1bdc2ac to 952223e Compare December 16, 2021 13:28
Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
The mod replaces are no longer required since helm v3.7.1.

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @relu

@stefanprodan stefanprodan merged commit bd6fc92 into main Jan 5, 2022
@stefanprodan stefanprodan deleted the go-v1.17 branch January 5, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants