Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use t.TempDir() where applicable instead of manually dealing with GC #3594

Closed
hiddeco opened this issue Feb 15, 2023 · 0 comments · Fixed by #4967
Closed

Use t.TempDir() where applicable instead of manually dealing with GC #3594

hiddeco opened this issue Feb 15, 2023 · 0 comments · Fixed by #4967
Labels
area/ci CI related issues and pull requests help wanted Extra attention is needed

Comments

@hiddeco
Copy link
Member

hiddeco commented Feb 15, 2023 •
edited
Loading

There is more here that could be done, as using ./testdata/ for something temporary seems wrong.

I think we should instead use t.TempDir() as a target for the file that is been written. Which would prevent having to think about garbage collecting it later on.

This is however beyond the time I have available now, as I was merely trying to fix things I ran into while working on #3587.

Originally posted by @hiddeco in #3592 (comment)

This is one example, but there may be more.
@hiddeco hiddeco added area/ci CI related issues and pull requests help wanted Extra attention is needed labels Feb 15, 2023
@mxtw mxtw mentioned this issue Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI related issues and pull requests help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: use tempdir to avoid manual gc mxtw/flux2
1 participant
@hiddeco