tests: only provide template values when used #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
fix-golden-files
branch
4 times, most recently
from
ed5cc8a to
66cd09e
Compare
As otherwise the `.golden` values can not be automatically updated using `-update` as documented in `CONTRIBUTING.md`. Also ensure we do not use `defer` but rather `t.Cleanup` in tests, as this will always be called even if e.g. `t.Fatal` absruptly stops the test. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
fix-golden-files
branch
from
66cd09e to
b263e14
Compare
hiddeco
commented
Feb 15, 2023
| @@ -171,8 +171,7 @@ spec: | |||
| if err != nil { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
There is more here that could be done, as using ./testdata/ for something temporary seems wrong.
I think we should instead use t.TempDir() as a target for the file that is been written. Which would prevent having to think about garbage collecting it later on.
This is however beyond the time I have available now, as I was merely trying to fix things I ran into while working on #3587.
This was referenced Feb 15, 2023
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
fix-golden-files
branch
from
98da40a to
1f5961d
Compare
As the other version has a different signature, but exists for a different build tag. Resulting in my IDE becoming absolutely confused when I tried to enable both at the same time. Opted for "exec" because this one shells out. Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As otherwise the
.goldenvalues can not be automatically updated using-updateas documented inCONTRIBUTING.md.Also ensure we do not use
deferbut rathert.Cleanupin tests, asthis will always be called even if e.g.
t.Fatalabruptly stops thetest.
Also fixed some other minor things I ran into, and filled issues for the
things that are beyond reach of time I have available.