Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging for errors coming from go-git-providers #3623

Closed
makkes opened this issue Feb 22, 2023 · 0 comments · Fixed by #4028
Closed

Improve messaging for errors coming from go-git-providers #3623

makkes opened this issue Feb 22, 2023 · 0 comments · Fixed by #4028
Labels
area/bootstrap Bootstrap related issues and pull requests

Comments

@makkes
Copy link
Member

makkes commented Feb 22, 2023

When go-git-providers isn't able to fetch repository details while bootstrapping it's hard to understand where the error has originated. Here is an error caused by the repository not being reachable because of missing proxy settings:

flux bootstrap github --owner=bar --repository=baz --branch=master --hostname=foo --token-auth --private=true --verbose --log-level=debug
connecting to foo
failed to get Git repository "https://foo/bar/baz": Get "https://foo/api/v3/bar/baz": Forbidden

We should prefix errors coming from go-git-providers with provider error: %w so it's easier to debug the cause.

@makkes makkes added the area/bootstrap Bootstrap related issues and pull requests label Feb 22, 2023
makkes pushed a commit that referenced this issue Jul 3, 2023
closes #3623

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Jul 3, 2023
closes #3623

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Jul 3, 2023
closes #3623

Signed-off-by: Max Jonas Werner <mail@makk.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant