Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AUR package templates #4224

Closed
relu opened this issue Sep 8, 2023 · 0 comments · Fixed by #4228
Closed

Improve AUR package templates #4224

relu opened this issue Sep 8, 2023 · 0 comments · Fixed by #4228
Labels
area/ci CI related issues and pull requests

Comments

@relu
Copy link
Member

relu commented Sep 8, 2023

Improvement recommendations from @FabioLolix on AUR: https://aur.archlinux.org/packages/flux-bin#comment-928509

Hello,

  • you can remove armv6h since that is has been removed from the distro
  • please remove ${pkgname}-${pkgver}.tar.gz:: from source_*=(), renaming all the files to the same name is detrimental if one need to use the command updpkgsums
  • improve pkgver/_srcver instead of duplicate it by using for example:
_srcver=2.0.0-rc.5
pkgver=${_srcver//-/.}

or

_srcver=2.0.0-rc.5
pkgver=${_srcver//-/}
@relu relu added the area/ci CI related issues and pull requests label Sep 8, 2023
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 11, 2023
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 11, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 12, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 12, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 12, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 12, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/flux2 that referenced this issue Sep 13, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
hiddeco pushed a commit to sonbui00/flux2 that referenced this issue Sep 19, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
github-actions bot pushed a commit that referenced this issue Sep 19, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
(cherry picked from commit bc90e7c)
github-actions bot pushed a commit that referenced this issue Sep 19, 2023
- remove armv6h #4224
- unique source name #4224
- improve pkgver/_srcver #4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
(cherry picked from commit f9e7190)
haggishunk pushed a commit to haggishunk/flux2 that referenced this issue Oct 10, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
Signed-off-by: Travis Mattera <travis@mattera.io>
haggishunk pushed a commit to haggishunk/flux2 that referenced this issue Oct 10, 2023
- remove armv6h fluxcd#4224
- unique source name fluxcd#4224
- improve pkgver/_srcver fluxcd#4224
- fix source name in .SRCINFO

Signed-off-by: Son Bui <sonbv00@gmail.com>
Signed-off-by: Travis Mattera <travis@mattera.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant