Improve warning about GitRepo HelmCharts #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
force-pushed
the
helm-git-source-warn
branch
from
cdd8d02
to
32b6297
Compare
hiddeco
reviewed
Mar 8, 2021
stealthybox
force-pushed
the
helm-git-source-warn
branch
2 times, most recently
from
74ea2c5
to
8e71993
Compare
hiddeco
reviewed
Mar 10, 2021
stealthybox
force-pushed
the
helm-git-source-warn
branch
from
6c94523
to
1f8348b
Compare
hiddeco
approved these changes
Mar 18, 2021
stealthybox
force-pushed
the
helm-git-source-warn
branch
from
1f8348b
to
b6008df
Compare
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com> Signed-off-by: leigh capili <leigh@null.net>
stealthybox
force-pushed
the
helm-git-source-warn
branch
from
b6008df
to
143a5fa
Compare
hiddeco
reviewed
Apr 23, 2021
|
|
||
| !!! warning "Arbitrary changes in Git do not produce new charts" | ||
| source-controller's `HelmChart` only publishes a new chart artifact when a commit | ||
| bumps the `version` field of the `Chart.yaml` referenced from the `GitRepository`. |
There was a problem hiding this comment.
Think that given there is progress on this limitation, it would be worth mentioning it, to not scare people away with something that is going to vanish soon.
|
Docs have moved to the website repo, please open a PR there. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by some recent Slack threads where users asked the same question.
These will unfortunately disappear at some point:
https://cloud-native.slack.com/archives/CLAJ40HV3/p1615232600147200