Delete custom resources during uninstall #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
enhancement
Remove Kustomizations, GitRepositories and HelmRepositories before deleting the toolkit controllers and CRDs.
stefanprodan
force-pushed
the
uninstall-crs
branch
from
948ad6f to
8e67cfd
Compare
hiddeco
approved these changes
Jul 23, 2020
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
Release v0.0.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Kustomizations, GitRepositories and HelmRepositories before deleting the toolkit controllers and CRDs. This ensures that GC finalizers are processed before control plane deletion.