Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ValuesFiles documentation #1296

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Add ValuesFiles documentation #1296

merged 1 commit into from
Apr 22, 2021

Conversation

arbourd
Copy link
Contributor

@arbourd arbourd commented Apr 19, 2021 •
edited
Loading

  • Changes valuesFile documentation to valuesFiles
  • Purposely did not reference valuesFile as we would like to move people towards the non-deprecated option
  • Updates source-controller/api to latest main (matching changes in helm-controller, source-controller)
  • Renames valuesFile var to valuesFiles

Continuation of fluxcd/source-controller#291, fluxcd/source-controller#305

@stefanprodan
Copy link
Member

You need to run make test then commit all the generated docs.

@stefanprodan stefanprodan added hold Issues and pull requests put on hold area/docs Documentation related issues and pull requests labels Apr 19, 2021
@arbourd
Copy link
Contributor Author

arbourd commented Apr 20, 2021 •
edited
Loading

Rebased against main with changes in helm-controller and source-controller are in main as well.

@arbourd @hiddeco
Add ValuesFiles documentation
ef079c5 
Signed-off-by: Dylan Arbour <arbourd@users.noreply.github.com>
@stefanprodan stefanprodan removed the hold Issues and pull requests put on hold label Apr 22, 2021
stefanprodan
stefanprodan approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @arbourd 🥇

@stefanprodan stefanprodan merged commit e9531e4 into fluxcd:main Apr 22, 2021
@arbourd arbourd deleted the values-files branch April 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arbourd @stefanprodan