Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Refactor integrations #1469

Merged
merged 7 commits into from
Jun 2, 2021

Conversation

stealthybox
Copy link
Member

@stealthybox stealthybox commented Jun 1, 2021

Some of these bases were pretty broken.
I've added a Makefile to vet all of the kustomize builds, so it's easier to verify that the config is stacking as intended and without error.

None of these should be breaking changes:

  1. Add Makefile to test integrations
  2. Add /kbin/kubectl to _base integrations
  3. Remove per-cloud /kbin/kubectl patches
  4. Fix GCP integration container image
  5. Template AzureIdentityBinding using $(AZ_IDENTITY_NAME) for integrations
  6. Remove unused kustomizeconfigs from integrations
  7. Fix eventhub integration config patches

It's worth noting that this Makefile is just for the integrations folder.
It could be useful for the whole manifests directory.
The only base that doesn't build on its own is monitoring/monitoring-config because it needs LoadRestrictionsNone.

@stealthybox stealthybox force-pushed the integrations-fixes branch 2 times, most recently from 0cbb817 to efa1621 Compare June 1, 2021 20:39
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @stealthybox for all the fixes 🥇

@stefanprodan stefanprodan merged commit e12db14 into fluxcd:main Jun 2, 2021
@stealthybox stealthybox deleted the integrations-fixes branch June 29, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants