Refactor test helpers

[stefanprodan]

Changes:

• move test helpers to main
• add support for inline golden values
• add test for flux --version

[hiddeco]

• Thank you Stefan 🙏

[allenporter]

Thanks, I had a similar PR in mind with some follow up improvements.

[stefanprodan]

One thing I forgot to do is to delete that init, tests should use func TestMain.

[stefanprodan]

Oh one more thing, the test helpers are using ioutil this needs to go away, see #1658

[allenporter]

Thanks, I was browsing issues and saw that and realized, I'll send a fix.

…

On Wed, Aug 4, 2021, 6:48 AM Stefan Prodan ***@***.***> wrote: Oh one more thing, the test helpers are using ioutil this needs to go away, see #1658 <#1658> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1682 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABN7JMWSTZVDACFYGV3HRZ3T3FAK3ANCNFSM5BQPON3A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[allenporter]

Moving to TestMain sounds good, will do. I'm assuming all tests that have times/dates in the golden files will need that setup -- that is a TestMain per test file. Is that right?

I also realize there could be side effects for changing the timezone across tests.

[allenporter]

I realize now, TestMain can do setup and teardown to handle restoring any environment variables.
But also, TestMain seems to be a test-wide initialization, rather than a per-test file initialization, so not necessary.