Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get subcommand column order #2467

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Update get subcommand column order #2467

merged 3 commits into from
Feb 28, 2022

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Feb 23, 2022 •
edited
Loading

  • Move READY and MESSAGE to the end of get subcommand output.
  • Add test flag -update to update the golden files.
  • Update the golden files based on the output change using.

Fixes #2385

Associated PRs:

@darkowlzz
Move MESSAGE to the end of get subcommand output
21f0d5d 
Message content could be long compared to other fields. Moving it to
the end helps improve the visibility of the other fields.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz force-pushed the update-get-column-order branch from 7ceceeb to 0a09ea9 Compare February 24, 2022 03:25
@darkowlzz
Add test flag -update to update the golden files
edaf6ca 
Test flag `-update` can be used to update all the golden files whenever
the CLI output changes.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz force-pushed the update-get-column-order branch from 0a09ea9 to edaf6ca Compare February 24, 2022 03:28
stefanprodan
stefanprodan reviewed Feb 25, 2022
View reviewed changes
cmd/flux/main_test.go Outdated Show resolved Hide resolved
@darkowlzz
test: ignore golden template files with -update
2c4c3fd 
Add a template values check in the `assertGoldenTemplateFile()` function
to only update golden files if they aren't templates. A note is printed
when an update to a template golden file is needed and `-update` flag
can't update it.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
stefanprodan
stefanprodan approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @darkowlzz

@stefanprodan stefanprodan merged commit 7e23430 into main Feb 28, 2022
@stefanprodan stefanprodan deleted the update-get-column-order branch February 28, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Message/Status to the end of kubectl/flux get
2 participants
@darkowlzz @stefanprodan