Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap git: Allow the password to be specified with GIT_PASSWORD env var #2631

Merged

Conversation

canidam
Copy link
Contributor

@canidam canidam commented Apr 8, 2022

Solves issue #2619

This PR align the generic bootstrap git command with bootstrap github and bootstrap gitlab, allowing the user to provide password using environment var GIT_PASSWORD or be prompted to provide it as an input.

Signed-off-by: Chen Anidam canidam@gmail.com

@canidam canidam force-pushed the add-bootstrap-git-pass-from-stdin-and-env branch from 4637d25 to 836e951 Compare April 12, 2022 08:45
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all .idea files, you can ignore them in your $HOME/.gitignore.

cmd/flux/bootstrap_git.go Outdated Show resolved Hide resolved
@canidam canidam force-pushed the add-bootstrap-git-pass-from-stdin-and-env branch from 836e951 to 5a8b64a Compare April 12, 2022 08:56
@stefanprodan
Copy link
Member

@canidam please squash all commits into a single one, signoff that commit, rebase with upstream main, then force push.

@canidam canidam force-pushed the add-bootstrap-git-pass-from-stdin-and-env branch 2 times, most recently from ebf34ee to 65ad194 Compare April 12, 2022 09:09
Signed-off-by: Chen Anidam <canidam@gmail.com>
@canidam canidam force-pushed the add-bootstrap-git-pass-from-stdin-and-env branch from 65ad194 to a85ea59 Compare April 12, 2022 09:17
@canidam canidam requested a review from stefanprodan April 12, 2022 09:18
@stefanprodan stefanprodan changed the title Read password of generic git bootstrap command from env or stdin bootstrap git: Allow the password to be specified with GIT_PASSWORD env var Apr 12, 2022
@stefanprodan stefanprodan added enhancement New feature or request area/bootstrap Bootstrap related issues and pull requests labels Apr 12, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @canidam

@stefanprodan stefanprodan merged commit 8b98919 into fluxcd:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants