Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create secret oci command #2920

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Add create secret oci command #2920

merged 4 commits into from
Jul 26, 2022

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jul 19, 2022

Fixes #2910

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama changed the title Add create secret OCI command Add create secret oci command Jul 19, 2022
Long: `The create secret oci command generates a Kubernetes secret with `,
Example: ` # Create an OCI authentication secret on disk and encrypt it with Mozilla SOPS
flux create secret oci podinfo-auth \
--url=ghcr.io \
Copy link
Member Author

@somtochiama somtochiama Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better name for this flag might be --registry since it expects the name of the docker registry e.g gchr.io or eu.gcr.io

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama marked this pull request as ready for review July 19, 2022 18:53
@stefanprodan stefanprodan added the area/oci OCI related issues and pull requests label Jul 26, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🌷

@stefanprodan stefanprodan merged commit ce2496e into fluxcd:oci Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants