Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff artifact command #3224

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add diff artifact command #3224

merged 1 commit into from
Oct 20, 2022

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Fixes #3194

/cc @stefanprodan

@developer-guy developer-guy changed the title feat: diff artifact capability added WIP: feat: diff artifact capability added Oct 19, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and golden files to make sure we don't break the behaviour of this command in the future.

cmd/flux/diff_artifact.go Outdated Show resolved Hide resolved
cmd/flux/diff_artifact.go Show resolved Hide resolved
cmd/flux/diff_artifact.go Outdated Show resolved Hide resolved
@stefanprodan stefanprodan changed the title WIP: feat: diff artifact capability added Add diff artifact command Oct 19, 2022
@stefanprodan stefanprodan marked this pull request as draft October 19, 2022 13:23
@developer-guy developer-guy marked this pull request as ready for review October 20, 2022 07:31
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the pkg replace and set oci/v0.14.0 in go.mod, then run make tidy and push.

cmd/flux/diff_artifact.go Outdated Show resolved Hide resolved
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@stefanprodan stefanprodan added area/oci OCI related issues and pull requests enhancement New feature or request labels Oct 20, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @developer-guy 🎖️

@stefanprodan stefanprodan merged commit 9f41efb into fluxcd:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement flux diff artifact
2 participants