RFC-0005: Artifact Revision format and introduction of Digest
#3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
changed the title
hiddeco
changed the title
hiddeco
force-pushed
the
rfc-artifact-revision-fmt
branch
6 times, most recently
from
c75fcb9
to
14e40a5
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
rfc-artifact-revision-fmt
branch
13 times, most recently
from
feddfe3
to
95da84a
Compare
pjbgf
reviewed
Oct 21, 2022
hiddeco
force-pushed
the
rfc-artifact-revision-fmt
branch
4 times, most recently
from
d585d22
to
6c66b04
Compare
souleb
approved these changes
Nov 4, 2022
hiddeco
force-pushed
the
rfc-artifact-revision-fmt
branch
from
f66cda9
to
46ae410
Compare
phillebaba
reviewed
Nov 7, 2022
hiddeco
force-pushed
the
rfc-artifact-revision-fmt
branch
from
46ae410
to
0e33ab8
Compare
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Various typo and structural fixes. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
- Properly refer to OCI repository name - Ensure checksum examples are unique to help distinguish difference between Revision and Digest - Slightly change proposal wordings to explicitly mention deprecation of `Checksum` field - Add reference to OCI digests spec Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
rfc-artifact-revision-fmt
branch
from
0e33ab8
to
86e3991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This RFC proposes to establish a canonical
Revisionformat for anArtifactwhich points to a specific revision represented as a checksum (e.g. an OCI
manifest digest or Git commit SHA) of a named pointer (e.g. an OCI image tag or
Git tag). In addition, it proposes to include the algorithm name (e.g.
sha256) as a prefix to an advertised checksum for anArtifactandfurther referring to it as a
Digest, deprecating theChecksumfield.Related to
github.com/opencontainers/go-digestfor checksums source-controller#855